Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to CollectSideEffectWithLifecycle #6587

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Aug 8, 2024


This change is Reviewable

Copy link

linear bot commented Aug 8, 2024

@Rawa Rawa added the Android Issues related to Android label Aug 8, 2024
@Rawa Rawa self-assigned this Aug 8, 2024
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 18 of 18 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is blocked, we should address the last 4 remaining LuanchedEffectCollect

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something can/should work on or should we mark it as "On hold"?

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things that needs discussing, but we can put it on hold since we have other things that are more important.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun added the On hold Means the PR is paused for some reason. No need to review it for now label Aug 20, 2024
@Rawa Rawa force-pushed the ensure-we-use-collectsideeffectwithlifecycle-droid-1186 branch from bb37926 to 09181fc Compare September 2, 2024 12:41
@Pururun Pururun removed the On hold Means the PR is paused for some reason. No need to review it for now label Sep 2, 2024
@Rawa Rawa force-pushed the ensure-we-use-collectsideeffectwithlifecycle-droid-1186 branch from 09181fc to 93a7faf Compare September 2, 2024 13:03
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 19 of 19 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the ensure-we-use-collectsideeffectwithlifecycle-droid-1186 branch from 93a7faf to 0cdcfb8 Compare September 2, 2024 13:38
@Rawa Rawa merged commit 71170a3 into main Sep 2, 2024
24 checks passed
@Rawa Rawa deleted the ensure-we-use-collectsideeffectwithlifecycle-droid-1186 branch September 2, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants