Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet Tunnel stuck in blocked state after Airplane mode is toggled. #6647

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ extension PacketTunnelActor {
currentKey: connState.currentKey,
keyPolicy: connState.keyPolicy,
networkReachability: connState.networkReachability,
recoveryTask: startRecoveryTaskIfNeeded(reason: reason),
priorState: priorState
)
}
Expand Down
6 changes: 3 additions & 3 deletions ios/PacketTunnelCore/Actor/State+Extensions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -188,16 +188,16 @@ extension BlockedStateReason {
- Keychain and filesystem are locked on boot until user unlocks device in the very first time.
- App update that requires settings schema migration. Packet tunnel will be automatically restarted after update but it would not be able to read settings until
user opens the app which performs migration.
- Packet tunnel will be automatically restarted when there is a tunnel adapter error.
*/
var shouldRestartAutomatically: Bool {
switch self {
case .deviceLocked:
case .deviceLocked, .tunnelAdapter:
return true

case .noRelaysSatisfyingConstraints, .noRelaysSatisfyingFilterConstraints,
.multihopEntryEqualsExit,
.noRelaysSatisfyingDaitaConstraints, .readSettings, .invalidAccount, .accountExpired, .deviceRevoked,
.tunnelAdapter, .unknown, .deviceLoggedOut, .outdatedSchema, .invalidRelayPublicKey:
.unknown, .deviceLoggedOut, .outdatedSchema, .invalidRelayPublicKey:
return false
}
}
Expand Down
4 changes: 2 additions & 2 deletions ios/PacketTunnelCore/Actor/Timings.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ import MullvadTypes

/// Struct holding all timings used by tunnel actor.
public struct PacketTunnelActorTimings {
/// Periodicity at which actor will attempt to restart when an error occurred on system boot when filesystem is locked until device is unlocked.
/// Periodicity at which actor will attempt to restart when an error occurred on system boot when filesystem is locked until device is unlocked or tunnel adapter error.
public var bootRecoveryPeriodicity: Duration

/// Time that takes for new WireGuard key to propagate across relays.
public var wgKeyPropagationDelay: Duration

/// Designated initializer.
public init(
bootRecoveryPeriodicity: Duration = .seconds(10),
bootRecoveryPeriodicity: Duration = .seconds(5),
wgKeyPropagationDelay: Duration = .seconds(120)
) {
self.bootRecoveryPeriodicity = bootRecoveryPeriodicity
Expand Down
47 changes: 46 additions & 1 deletion ios/PacketTunnelCoreTests/PacketTunnelActorTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ import Combine
@testable import MullvadSettings
import MullvadTypes
import Network
@testable import PacketTunnelCore
import WireGuardKitTypes
import XCTest

@testable import PacketTunnelCore

final class PacketTunnelActorTests: XCTestCase {
private var stateSink: Combine.Cancellable?
private let launchOptions = StartOptions(launchSource: .app)
Expand Down Expand Up @@ -446,6 +447,48 @@ final class PacketTunnelActorTests: XCTestCase {
actor.reconnect(to: .random, reconnectReason: .userInitiated)
await fulfillment(of: [stopMonitorExpectation], timeout: .UnitTest.timeout)
}

func testRecoveringConnectionAfterTunnelAdaptorError() async throws {
let errorStateExpectation = expectation(description: "Expect error state")
let connectingStateExpectation = expectation(description: "Expect connecting state")
connectingStateExpectation.expectedFulfillmentCount = 2
let connectedStateExpectation = expectation(description: "Expect connected state")

let blockedStateMapper = BlockedStateErrorMapperStub { error in
if error is TunnelAdapterErrorStub {
return .tunnelAdapter
} else {
return .unknown
}
}

let actor = PacketTunnelActor.mock(blockedStateErrorMapper: blockedStateMapper)

actor.start(options: launchOptions)

stateSink = await actor.$observedState
.receive(on: DispatchQueue.main)
.sink { newState in
switch newState {
case .error:
errorStateExpectation.fulfill()
case .connecting:
connectingStateExpectation.fulfill()
case .connected:
connectedStateExpectation.fulfill()
default:
break
}
}

actor.setErrorState(reason: .tunnelAdapter)

await fulfillment(
of: [errorStateExpectation, connectingStateExpectation, connectedStateExpectation],
timeout: .UnitTest.timeout,
enforceOrder: true
)
}
}

extension PacketTunnelActorTests {
Expand All @@ -470,4 +513,6 @@ extension PacketTunnelActorTests {
}
}

struct TunnelAdapterErrorStub: Error {}

// swiftlint:disable:this file_length
Loading