Add UI for DAITA in VPN settings

[mojganii]

This PR introduces the ability to toggle Daita in settings:

before	after

---

This change is 

[linear]

IOS-794 Add DAITA UI part

[rablador]

Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mojganii)

---

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsDataSource.swift line 643 at r1 (raw file):

            } onDiscard: { [weak self] in
                guard let self else { return }
                tableView?.reloadData()

Why do we need to manually reload the tableView here?

---

ios/PacketTunnelCoreTests/PacketTunnelActorTests.swift line 449 at r1 (raw file):

        await fulfillment(of: [stopMonitorExpectation], timeout: .UnitTest.timeout)
    }

Leftover?

[buggmagnet]

Reviewed 15 of 16 files at r1.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @mojganii)

---

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsViewController.swift line 192 at r1 (raw file):

            tableName: "DAITA",
            value: """
            DAITA (Defence against AI-guided Traffic Analysis) hides patterns in your encrypted VPN traffic.\

The text needs some spaces here and there.

---

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsViewController.swift line 235 at r1 (raw file):

                    tableName: "DAITA",
                    value: """
                    This feature isn't available on all servers.\

Same here, the text needs some extra spaces

---

ios/PacketTunnelCore/Actor/PacketTunnelActor+ErrorState.swift line 107 at r1 (raw file):

            keyPolicy: connState.keyPolicy,
            networkReachability: connState.networkReachability,
            recoveryTask: startRecoveryTaskIfNeeded(reason: reason),

Why are we adding this here ?

[mojganii]

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @buggmagnet and @rablador)

---

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsDataSource.swift line 643 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Why do we need to manually reload the tableView here?

To turn the toggle off if user taps back button in the dialog.

---

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsViewController.swift line 192 at r1 (raw file):

Previously, buggmagnet wrote…

The text needs some spaces here and there.

Done.

---

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsViewController.swift line 235 at r1 (raw file):

Previously, buggmagnet wrote…

Same here, the text needs some extra spaces

Done.

---

ios/PacketTunnelCore/Actor/PacketTunnelActor+ErrorState.swift line 107 at r1 (raw file):

Previously, buggmagnet wrote…

Why are we adding this here ?

the branch must be rebased with main. now it's updated and resolved

---

ios/PacketTunnelCoreTests/PacketTunnelActorTests.swift line 449 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Leftover?

Solved.

[buggmagnet]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @rablador)

[buggmagnet]

Dismissing @rablador so we can merge the PR as all his claims have been adressed

Dismissed @rablador from 2 discussions.
Reviewable status: all files reviewed, 2 unresolved discussions

Reviewer is satisfied, just unavailable to say they are

[github-actions]

🚨 End to end tests failed. Please check the failed workflow run.