Update rexml for vulnerability issues #6695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
reviewed
Aug 28, 2024
There was a problem hiding this comment.
Nice! Please include in the PR to revert 489f616 if you are no longer vulnerable to CVE-2024-43398
Reviewable status: 0 of 2 files reviewed, all discussions resolved
buggmagnet
force-pushed
the
fix-rexml-once-again-ios-part-3
branch
from
d3f13a7 to
19af02d
Compare
buggmagnet
requested review from
raksooo,
pinkisemils and
albin-mullvad
as code owners
buggmagnet
commented
Aug 29, 2024
There was a problem hiding this comment.
Done !
Reviewable status: 0 of 4 files reviewed, all discussions resolved
faern
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
buggmagnet
force-pushed
the
fix-rexml-once-again-ios-part-3
branch
from
19af02d to
2ffdc0e
Compare
This reverts commit 489f616.
buggmagnet
force-pushed
the
fix-rexml-once-again-ios-part-3
branch
from
2ffdc0e to
6c05bfc
Compare
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
rexmldependency we use for running screenshots to a version not known to be vulnerable.This change is