Filter only on reassembled packets in PF #6738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
previously approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)
talpid-core/src/firewall/macos.rs line 164 at r1 (raw file):
fn get_scrub_rules() -> Result<Vec<pfctl::ScrubRule>> { let scrub_rule = pfctl::ScrubRuleBuilder::default()
If we just add a small comment about this rule I'm happy with the PR! The rule itself is not very self explanatory. Just a quick note about this rule being required to make PF process reassembled packets, not fragments.
dlon
force-pushed
the
reassemble-before-pf-filter
branch
3 times, most recently
from
e49e68b to
a71423e
Compare
faern
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
This fixes an issue of fragments being blocked by PF, causing instability and timeouts
dlon
force-pushed
the
reassemble-before-pf-filter
branch
from
a71423e to
5740b9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue of fragments being blocked by PF. This was primarily noticed when using Shadowsocks and PQ but it fixes other issues as well.
Fix DES-1212.
This change is