-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cbindgen to the android build container #6811
Add cbindgen to the android build container #6811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
76b6103
to
52b1aed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
android/docker/Dockerfile
line 119 at r1 (raw file):
# This is an intermediate solution that will be further improved as part of # issue: DROID-1328. RUN cargo install --force cbindgen --version "0.26.0"
Would be cool if we could clean the global cargo
cache after installing cbindgen
😊
Code quote:
RUN cargo install --force cbindgen --version "0.26.0"
53b14c6
52b1aed
to
53b14c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @MarkusPettersson98, @Pururun, and @Rawa)
android/docker/Dockerfile
line 119 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
Would be cool if we could clean the global
cargo
cache after installingcbindgen
😊
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
android/docker/Dockerfile
line 119 at r1 (raw file):
Previously, albin-mullvad wrote…
Done!
🎉
53b14c6
to
424e674
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
424e674
to
e966554
Compare
This PR aims to add
cbindgen
as part of the Android build container. This is an improvement to how it was added in multiple build scripts and workflows in #6684 as well as #6808 and #6757 (which will be partially reverted after the new container image has been published). We also aim to improve this further as part of our internal issue: DROID-1328.This change is