Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mullvad status -v not printing udp2tcp port and transport protocol #6815

Conversation

MarkusPettersson98
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Sep 18, 2024

Fixes a regression in the CLI since last stable release.


This change is Reviewable

Copy link

linear bot commented Sep 18, 2024

@MarkusPettersson98 MarkusPettersson98 force-pushed the display-correct-port-in-cli-for-wireguard-obfuscation-des-1247 branch from a908741 to 9ddafdd Compare September 19, 2024 03:53
Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)


mullvad-cli/src/format.rs line 258 at r1 (raw file):

        location.and_then(|l| l.hostname.as_deref()),
        // Check if we *actually* want to print an obfuscator endpoint ..
        // The obfuscator information should be printed for the entry relay only.

Nit: "The obfuscator information should be printed for the exit relay if multihop is disabled"
May be slightly clearer

@MarkusPettersson98 MarkusPettersson98 force-pushed the display-correct-port-in-cli-for-wireguard-obfuscation-des-1247 branch from 9ddafdd to ab1bc4b Compare September 19, 2024 07:59
Copy link
Contributor Author

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Serock3)


mullvad-cli/src/format.rs line 258 at r1 (raw file):

Previously, Serock3 (Sebastian Holmin) wrote…

Nit: "The obfuscator information should be printed for the exit relay if multihop is disabled"
May be slightly clearer

Done

Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@MarkusPettersson98 MarkusPettersson98 merged commit 5a7bf69 into main Sep 19, 2024
50 of 51 checks passed
@MarkusPettersson98 MarkusPettersson98 deleted the display-correct-port-in-cli-for-wireguard-obfuscation-des-1247 branch September 19, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants