Fix all baselined lint issues

[Rawa]

---

This change is 

[linear]

DROID-218 Fix all baselined lint issues

[albin-mullvad]

Reviewed 13 of 19 files at r1.
Reviewable status: 13 of 19 files reviewed, 2 unresolved discussions (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/extensions/ResourcesExtensions.kt line 15 at r1 (raw file):

}

@Suppress("MagicNumber")

Please add a comment regarding this suppression

Code quote:

@Suppress("MagicNumber")

---

android/lib/talpid/src/main/kotlin/net/mullvad/talpid/TalpidVpnService.kt line 77 at r1 (raw file):

    }

    @Suppress("ReturnCount")

Please add a comment regarding this suppression

Code quote:

@Suppress("ReturnCount")

[albin-mullvad]

Reviewed 5 of 19 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Rawa)

[Pururun]

Reviewed 25 of 25 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Rawa)

---

android/app/src/main/AndroidManifest.xml line 30 at r3 (raw file):

                 android:banner="@mipmap/ic_banner"
                 android:allowBackup="false"
                 android:fullBackupContent="@xml/full_back_content"

Have we made sure we haven't accidentally changed the backup behaviour? We could potentially backup and send sensitive data.

[Rawa]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/app/src/main/AndroidManifest.xml line 30 at r3 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Have we made sure we haven't accidentally changed the backup behaviour? We could potentially backup and send sensitive data.

According to the android documentation this should not cause any data transfers. I've explicitly excluded all domains that exists as options to backup.

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/extensions/ResourcesExtensions.kt line 15 at r1 (raw file):

Previously, albin-mullvad wrote…

Please add a comment regarding this suppression

Reworked this to get rid of the magic number. Looked at the desktop implementation where the similar code exists but they in actuality never use the months. Also they only show years if it is more than 2, so I fixed that as well.

---

android/lib/talpid/src/main/kotlin/net/mullvad/talpid/TalpidVpnService.kt line 77 at r1 (raw file):

Previously, albin-mullvad wrote…

Please add a comment regarding this suppression

Added comment and referenced a ticket.

[albin-mullvad]

Mostly looks good, just a few minor comments to address

Reviewed 25 of 25 files at r3, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @Pururun and @Rawa)

---

android/app/src/main/res/xml/data_extraction_rules.xml line 21 at r3 (raw file):

        <exclude domain="external" />
    </device-transfer>
</data-extraction-rules>

bad eof

---

android/app/src/main/res/xml/full_back_content.xml line 16 at r3 (raw file):

    <exclude domain="device_sharedpref" />
    <exclude domain="device_root" />
</full-backup-content>

bad eof

---

android/lib/resource/build.gradle.kts line 24 at r3 (raw file):

    }

    lint {

Is this lint config needed when we use checkDependencies?

---

android/lib/resource/src/main/res/values/ic_banner_background.xml line 4 at r3 (raw file):

<resources>
    <color name="ic_banner_background">#192E45</color>
</resources>

bad eof

---

android/lib/talpid/src/main/kotlin/net/mullvad/talpid/TalpidVpnService.kt line 78 at r3 (raw file):

    // DROID-1407
    // Function is to be cleaned up and lint warning to be removed.

Should it be lint suppression?

Code quote:

lint warning 

[Pururun]

Reviewed all commit messages.
Reviewable status: 37 of 57 files reviewed, 5 unresolved discussions (waiting on @albin-mullvad and @Rawa)

---

android/app/src/main/AndroidManifest.xml line 30 at r3 (raw file):

Previously, Rawa (David Göransson) wrote…

According to the android documentation this should not cause any data transfers. I've explicitly excluded all domains that exists as options to backup.

Tested on Android 14 and nothing is backed up ⭐

[Pururun]

Reviewed 20 of 20 files at r4.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @Rawa)

[Rawa]

Reviewable status: 31 of 58 files reviewed, 5 unresolved discussions (waiting on @albin-mullvad and @Pururun)

---

android/app/src/main/res/xml/data_extraction_rules.xml line 21 at r3 (raw file):

Previously, albin-mullvad wrote…

bad eof

Done.

---

android/lib/resource/build.gradle.kts line 24 at r3 (raw file):

Previously, albin-mullvad wrote…

Is this lint config needed when we use checkDependencies?

As discussed, we leave them kept, since they are needed.

---

android/lib/resource/src/main/res/values/ic_banner_background.xml line 4 at r3 (raw file):

Previously, albin-mullvad wrote…

bad eof

Done.

---

android/app/src/main/res/xml/full_back_content.xml line 16 at r3 (raw file):

Previously, albin-mullvad wrote…

bad eof

Done.

[Rawa]

Reviewable status: 31 of 58 files reviewed, 4 unresolved discussions (waiting on @albin-mullvad and @Pururun)

---

android/lib/talpid/src/main/kotlin/net/mullvad/talpid/TalpidVpnService.kt line 78 at r3 (raw file):

Previously, albin-mullvad wrote…

Should it be lint suppression?

Fixed.

---

android/lib/resource/src/main/res/values/ic_banner_background.xml line 4 at r3 (raw file):

Previously, Rawa (David Göransson) wrote…

Done.

(Removed it and used other color asset)

[albin-mullvad]

Reviewed 27 of 27 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

---

android/lib/resource/build.gradle.kts line 24 at r3 (raw file):

Previously, Rawa (David Göransson) wrote…

As discussed, we leave them kept, since they are needed.

👍