Fix duplicated incoming packets when split tunneling is enabled #6924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hulthe
previously approved these changes
Oct 4, 2024
hulthe
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents incoming packets from private IPs from being forwarded to the VPN tun, which previously caused incoming packets on the LAN (notably/noticeably ICMP) to be duplicated.
The correct implementation would be to forward only packets that weren't originally sent via the VPN utun. For simplicity, the proposed implementation discards packets destined for private IP ranges. This is so we don't have to rely on the routing table.
Unrelatedly, don't kill states related to API traffic (
allowed_endpoint) when flushing PF states.Fix DES-1217.
This change is