-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move changelog to settings #6989
Conversation
190876c
to
90cbd8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 19 of 20 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/InAppNotificationController.kt
line 65 at r2 (raw file):
combine( tunnelStateNotificationUseCase().onEach { Logger.d("tunnelStateNotificationUseCase: $it")
Excessive logging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Rawa)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/AppInfoScreen.kt
line 115 at r2 (raw file):
context.resources .getString(R.string.download_url) .appendHideNavOnPlayBuild(state.isPlayBuild)
This is never true so could be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion
android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/InAppNotificationController.kt
line 65 at r2 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
Excessive logging?
Mistake, removed it now. It was left when fixing accountExpiryInAppNotificationUseCase
.
5099ce0
to
1a0a291
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 18 of 18 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
1a0a291
to
b71e78a
Compare
This change is