Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move changelog to settings #6989

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Move changelog to settings #6989

merged 4 commits into from
Oct 18, 2024

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Oct 16, 2024


This change is Reviewable

@Rawa Rawa added the Android Issues related to Android label Oct 16, 2024
@Rawa Rawa self-assigned this Oct 16, 2024
Copy link

linear bot commented Oct 16, 2024

@Rawa Rawa force-pushed the move-changelog-to-settings-droid-1414 branch from 190876c to 90cbd8c Compare October 16, 2024 07:18
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 20 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/InAppNotificationController.kt line 65 at r2 (raw file):

        combine(
                tunnelStateNotificationUseCase().onEach {
                    Logger.d("tunnelStateNotificationUseCase: $it")

Excessive logging?

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Rawa)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/AppInfoScreen.kt line 115 at r2 (raw file):

                                context.resources
                                    .getString(R.string.download_url)
                                    .appendHideNavOnPlayBuild(state.isPlayBuild)

This is never true so could be removed

Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion


android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/InAppNotificationController.kt line 65 at r2 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Excessive logging?

Mistake, removed it now. It was left when fixing accountExpiryInAppNotificationUseCase.

@Rawa Rawa force-pushed the move-changelog-to-settings-droid-1414 branch 2 times, most recently from 5099ce0 to 1a0a291 Compare October 18, 2024 06:49
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 18 of 18 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the move-changelog-to-settings-droid-1414 branch from 1a0a291 to b71e78a Compare October 18, 2024 07:39
@Rawa Rawa merged commit 8ffc8d3 into main Oct 18, 2024
31 checks passed
@Rawa Rawa deleted the move-changelog-to-settings-droid-1414 branch October 18, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants