Make Smart routing override Multihop #6996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPettersson98
force-pushed
the
make-sure-to-use-a-daita-compatible-entry-even-if-the-exit-des-1303
branch
6 times, most recently
from
53afeb4 to
816a7c0
Compare
MarkusPettersson98
force-pushed
the
make-sure-to-use-a-daita-compatible-entry-even-if-the-exit-des-1303
branch
from
816a7c0 to
b37a04d
Compare
Serock3
reviewed
Oct 18, 2024
Serock3
reviewed
Oct 18, 2024
MarkusPettersson98
force-pushed
the
make-sure-to-use-a-daita-compatible-entry-even-if-the-exit-des-1303
branch
from
9fe8259 to
5e88e55
Compare
Serock3
reviewed
Oct 18, 2024
Serock3
reviewed
Oct 18, 2024
Serock3
reviewed
Oct 18, 2024
Serock3
reviewed
Oct 18, 2024
MarkusPettersson98
force-pushed
the
make-sure-to-use-a-daita-compatible-entry-even-if-the-exit-des-1303
branch
from
5e88e55 to
2c27d57
Compare
Serock3
reviewed
Oct 18, 2024
Serock3
reviewed
Oct 18, 2024
MarkusPettersson98
force-pushed
the
make-sure-to-use-a-daita-compatible-entry-even-if-the-exit-des-1303
branch
from
2c27d57 to
c19c9a0
Compare
Serock3
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 4 of 4 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, 4 of 8 files at r14, 1 of 1 files at r20, 1 of 2 files at r31, 1 of 1 files at r32, 6 of 6 files at r33, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MarkusPettersson98)
MarkusPettersson98
force-pushed
the
make-sure-to-use-a-daita-compatible-entry-even-if-the-exit-des-1303
branch
from
e386659 to
74fe671
Compare
If both multihop and DAITA (with smart routing) is enabled, a DAITA-compatible entry relay will be selected. This implies that if the user has selected an entry relay which is not DAITA-enabled, the relay selector will override this choice and force a DAITA-enabled relay as entry. If smart routing is disabled in this case, the user's selected entry will always be selected, even if this means that the user will end up in a blocked state.
MarkusPettersson98
force-pushed
the
make-sure-to-use-a-daita-compatible-entry-even-if-the-exit-des-1303
branch
from
74fe671 to
a416d9d
Compare
MarkusPettersson98
deleted the
make-sure-to-use-a-daita-compatible-entry-even-if-the-exit-des-1303
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes to
mullvad-relay-selectorfor making Smart routing override Multihop. It also includes some drive-by changes intended to make it easier to follow what's happening in the relay selector.How it works
If both multihop and DAITA (with smart routing) is enabled, a DAITA-enabled entry relay will be selected. If the user has selected an entry relay which is not DAITA-enabled, the relay selector will override the user's choice and force a DAITA-enabled relay as entry. If smart routing is subsequently disabled, the user's selected entry will always be selected even if this means that the user will end up in a blocked state.
This change is