-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare android/2024.8-beta2 #7073
Prepare android/2024.8-beta2 #7073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Rawa)
android/CHANGELOG.md
line 30 at r1 (raw file):
I suggest rephrasing a bit to avoid anyone misinterpreting it as a permanent connection loss or that it would leak.
Improve connection stability when roaming while using Shadowsocks.
Code quote:
would lead to loss of connection.
android/src/main/play/release-notes/en-US/default.txt
line 2 at r1 (raw file):
I suggest mentioning that result of this for anyone that aren't aware of what MTU is. Perhaps something like this:
Fix MTU calculation to avoid connectivity issues when using some specific settings.
We could mention also mention which specific setting.
f5adf4d
to
3ddea93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @albin-mullvad)
android/src/main/play/release-notes/en-US/default.txt
line 2 at r1 (raw file):
Previously, albin-mullvad wrote…
I suggest mentioning that result of this for anyone that aren't aware of what MTU is. Perhaps something like this:
Fix MTU calculation to avoid connectivity issues when using some specific settings.
We could mention also mention which specific setting.
Updated the string to be more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
android/src/main/play/release-notes/en-US/default.txt
line 2 at r1 (raw file):
Previously, Rawa (David Göransson) wrote…
Updated the string to be more clear.
Good improvement, but I still think we can clarify a bit further what the impact would be for a user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
3ddea93
to
e02ed68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
This change is