Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect whether full-disk access is enabled in the split tunneling view #7098

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

dlon
Copy link
Member

@dlon dlon commented Oct 29, 2024

Previously, the app wouldn't detect this and end up in the blocked state. It will now show this information before split tunneling can be enabled:

Fix DES-1185.


This change is Reviewable

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 13 files at r1, all commit messages.
Reviewable status: 6 of 13 files reviewed, 1 unresolved discussion (waiting on @dlon)


talpid-core/src/split_tunnel/macos/process.rs line 28 at r1 (raw file):

const SHUTDOWN_TIMEOUT: Duration = Duration::from_secs(3);
const EARLY_FAIL_TIMEOUT: Duration = Duration::from_millis(100);

Just curious, why was this value lowered from 500 millis to 100 millis? 😊

Code quote:

const EARLY_FAIL_TIMEOUT: Duration = Duration::from_millis(100);

Copy link
Member Author

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 13 files at r1, all commit messages.
Reviewable status: 6 of 13 files reviewed, 1 unresolved discussion (waiting on @dlon and @MarkusPettersson98)


talpid-core/src/split_tunnel/macos/process.rs line 28 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Just curious, why was this value lowered from 500 millis to 100 millis? 😊

The process will remain open for this duration if it doesn't exit due to an error (i.e., full-disk access not being granted). 🙈 500 milliseconds is much more noticeable, and I think it is excessive.

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: 5 of 13 files reviewed, all discussions resolved (waiting on @dlon)

@dlon dlon force-pushed the macos-st-prompt-on-use branch from 0f495aa to 240fe6e Compare October 29, 2024 15:33
@dlon dlon merged commit 72b4281 into main Oct 29, 2024
59 of 60 checks passed
@dlon dlon deleted the macos-st-prompt-on-use branch October 29, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants