Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for parsing maybenot machines #7107

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Add unit test for parsing maybenot machines #7107

merged 3 commits into from
Nov 1, 2024

Conversation

dlon
Copy link
Member

@dlon dlon commented Oct 30, 2024


This change is Reviewable

@dlon dlon requested a review from hulthe October 30, 2024 17:58
@dlon dlon force-pushed the add-maybenot-test branch from cb12b39 to 1c224df Compare October 30, 2024 18:00
hulthe
hulthe previously approved these changes Oct 30, 2024
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)


wireguard-go-rs/src/lib.rs line 215 at r2 (raw file):

        Err(Error::Other)
    }
}

This function should have a docstring and SAFETY-comments imo

@dlon dlon force-pushed the add-maybenot-test branch from abbf556 to a7c59ca Compare October 31, 2024 15:10
Copy link
Member Author

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @hulthe)


wireguard-go-rs/src/lib.rs line 215 at r2 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

This function should have a docstring and SAFETY-comments imo

Done.

Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon force-pushed the add-maybenot-test branch from a7c59ca to b1b757e Compare November 1, 2024 09:16
@dlon dlon merged commit dfa90cb into main Nov 1, 2024
49 checks passed
@dlon dlon deleted the add-maybenot-test branch November 1, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants