Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for overriding API environment in E2E tests #7182

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Conversation

dlon
Copy link
Member

@dlon dlon commented Nov 14, 2024

Fix DES-1051.


This change is Reviewable

Copy link

linear bot commented Nov 14, 2024

@dlon dlon force-pushed the test-add-env-flag branch from 916879c to 91e52ad Compare November 15, 2024 09:11
@dlon dlon force-pushed the test-add-env-flag branch 3 times, most recently from b3aecca to 3ed760d Compare November 15, 2024 10:38
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 6 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


test/test-manager/src/main.rs line 77 at r4 (raw file):

        display: bool,

        /// API and conncheck environment to use, such as "mullvad.net" or "stagemole.eu".

⛏️ It is not that necessary to list mullvad.net and stagemole.eu in the comment, since it will be printed as part of the help text when invoking test-runner run-tests --help

$ cargo run --bin test-manager -- run-tests --help
Spawn a runner instance and run tests
..
Options:
      ..
      --mullvad-host <MULLVAD_HOST>
          API and conncheck environment to use, such as "mullvad.net" or "stagemole.eu". The domain name will be prefixed with "api." and "ipv4.am.i."

          [possible values: mullvad.net, stagemole.eu, devmole.eu]
      ..

Code quote:

 /// API and conncheck environment to use, such as "mullvad.net" or "stagemole.eu".

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon force-pushed the test-add-env-flag branch from 105c3d8 to ad6e667 Compare November 18, 2024 09:13
@dlon dlon merged commit 244d006 into main Nov 18, 2024
39 checks passed
@dlon dlon deleted the test-add-env-flag branch November 18, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants