Remove settings migration test ios 866

[mojganii]

This PR removes settings migration from CI due to the high maintenance cost of the tests. It is now intended to be run locally before release.

---

This change is 

[linear]

IOS-866 Remove settings migration test

[mojganii]

Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion

---

ios/MullvadVPN.xcodeproj/xcshareddata/xcschemes/MullvadVPN.xcscheme line 338 at r1 (raw file):

      buildConfiguration = "Release"
      revealArchiveInOrganizer = "YES">
      <PreActions>

I'm not sure if it's a good way to remind app's publisher to test SettingsMigration before release. maybe we don't need to have this or we can put it in release note. any idea?

[buggmagnet]

Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @mojganii)

---

ios/MullvadVPN.xcodeproj/xcshareddata/xcschemes/MullvadVPN.xcscheme line 338 at r1 (raw file):

Previously, mojganii wrote…

I'm not sure if it's a good way to remind app's publisher to test SettingsMigration before release. maybe we don't need to have this or we can put it in release note. any idea?

I think it's nice, but realistically, only the person doing the release would see this, so it will be moot for most people writing code.
Instead, we should make sure our release process cannot be finished without completing migration tests, in a way or another.

[mojganii]

Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @pinkisemils and @rablador)

---

ios/MullvadVPN.xcodeproj/xcshareddata/xcschemes/MullvadVPN.xcscheme line 338 at r1 (raw file):

Previously, buggmagnet wrote…

I think it's nice, but realistically, only the person doing the release would see this, so it will be moot for most people writing code.
Instead, we should make sure our release process cannot be finished without completing migration tests, in a way or another.

So we can have a bash script which running either by Xcode project or Fastlane . let's know other opinions as well @pinkisemils @rablador

[mojganii]

Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @pinkisemils and @rablador)

---

ios/MullvadVPN.xcodeproj/xcshareddata/xcschemes/MullvadVPN.xcscheme line 338 at r1 (raw file):

Previously, mojganii wrote…

So we can have a bash script which running either by Xcode project or Fastlane . let's know other opinions as well @pinkisemils @rablador

It's agreed to add that in release checklist.

[rablador]

Reviewed 11 of 14 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

[buggmagnet]

Reviewed 11 of 14 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[github-actions]

🚨 End to end tests failed. Please check the failed workflow run.