Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GHA Dependencies #7223

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

tinyboxvk
Copy link
Contributor

@tinyboxvk tinyboxvk commented Nov 22, 2024

Fixes some deprecation warnings in GHA.

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/download-artifact@v4, actions/upload-artifact@v4.
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "fedora40_report", "linux-build", "summary.html".
Please update your workflow to use v4 of the artifact actions.
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files.

This change is Reviewable

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 30 of 30 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98
Copy link
Contributor

Thanks a lot for your contribution! 💛
Sorry for leaving you hanging for a couple of days 😊

Copy link
Member

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 30 of 30 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98
Copy link
Contributor

Hello @tinyboxvk, would you mind rebasing your commit onto main? We don't merge main into branches before merge. Thank you 🙏

Signed-off-by: tinyboxvk <[email protected]>
@tinyboxvk
Copy link
Contributor Author

Hello @tinyboxvk, would you mind rebasing your commit onto main? We don't merge main into branches before merge. Thank you 🙏

Done. Thanks for letting me know. Wasn't sure about the process.

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98 MarkusPettersson98 merged commit d3b1ee9 into mullvad:main Nov 27, 2024
5 checks passed
@MarkusPettersson98
Copy link
Contributor

Done. Thanks for letting me know. Wasn't sure about the process.

I noticed now that we don't really mention it in CONTRIBUTING.md, so that's on us. Thanks again for your contribution! 💛

@tinyboxvk tinyboxvk deleted the patch-actions branch November 27, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants