-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add daemon CI job for Windows ARM64 #7258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dlon)
.github/workflows/daemon.yml
line 137 at r1 (raw file):
- name: Install Protoc if: ${{ matrix.config.arch == 'x64' }}
do we not need protoc on arm?
.github/workflows/daemon.yml
line 144 at r1 (raw file):
- name: Calculate Windows libraries cache hash if: ${{ matrix.config.arch == 'x64' }} id: windows-modules-hash
do we not need/want this on arm?
.github/workflows/daemon.yml
line 154 at r1 (raw file):
- name: Cache Windows libraries if: ${{ matrix.config.arch == 'x64' }}
do we not need/want this on arm?
.github/workflows/daemon.yml
line 183 at r1 (raw file):
- name: Install msbuild if: ${{ matrix.config.arch == 'x64' }}
do we not need msbuild on arm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @hulthe)
.github/workflows/daemon.yml
line 137 at r1 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
do we not need protoc on arm?
It's installed on the runner, so I figured it was wasteful to keep it. Let's enable it and see if anything breaks.
.github/workflows/daemon.yml
line 144 at r1 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
do we not need/want this on arm?
Let's enable it and see if it just works.
.github/workflows/daemon.yml
line 154 at r1 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
do we not need/want this on arm?
Let's enable it and see if it just works.
.github/workflows/daemon.yml
line 183 at r1 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
do we not need msbuild on arm?
It's installed on the runner, so I figured it was wasteful to keep it. Let's enable it and see if anything breaks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
.github/workflows/daemon.yml
line 137 at r1 (raw file):
Previously, dlon (David Lönnhager) wrote…
It's installed on the runner, so I figured it was wasteful to keep it. Let's enable it and see if anything breaks.
Makes sense. If it cuts down on run time, I'm all for it. Any if arch
guards here should imo be documented though
.github/workflows/daemon.yml
line 183 at r1 (raw file):
Previously, dlon (David Lönnhager) wrote…
It's installed on the runner, so I figured it was wasteful to keep it. Let's enable it and see if anything breaks.
👍 See my other comment
ddcc05a
to
7f037fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
.github/workflows/daemon.yml
line 137 at r1 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
Makes sense. If it cuts down on run time, I'm all for it. Any
if arch
guards here should imo be documented though
Done.
.github/workflows/daemon.yml
line 183 at r1 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
👍 See my other comment
I left it in in this case. This action detects that it is already installed, so it saves no time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
This PR doesn't include clippy, since those are (probably) not architecture-dependent, or the
test
workspace for now. It also does not include GUI or full E2E tests.Close DES-1120
This change is