Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using securedunsecure verbs in main view ios 893 #7277

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

buggmagnet
Copy link
Contributor

@buggmagnet buggmagnet commented Dec 3, 2024

This PR removes the "Secured / Unsecured" terminology from the app, and replaces it with "Connected" / "Disconnected"
It also removes a Unit Test class that was not being in use.

⚠️ I'm creating this as a draft PR because we don't want to merge this until we have shipped WireGuard over Shadowsocks


This change is Reviewable

@buggmagnet buggmagnet added the iOS Issues related to iOS label Dec 3, 2024
@buggmagnet buggmagnet requested review from mojganii and acb-mv December 3, 2024 15:22
@buggmagnet buggmagnet self-assigned this Dec 3, 2024
Copy link

linear bot commented Dec 3, 2024

@buggmagnet buggmagnet marked this pull request as ready for review December 4, 2024 06:02
mojganii
mojganii previously approved these changes Dec 5, 2024
Copy link
Collaborator

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 9 files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the stop-using-securedunsecure-verbs-in-main-view-ios-893 branch from ba54eba to 17f7919 Compare December 6, 2024 08:13
@buggmagnet buggmagnet force-pushed the stop-using-securedunsecure-verbs-in-main-view-ios-893 branch from 17f7919 to 3e111f7 Compare December 11, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants