Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for android/2024.9 #7307

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Dec 9, 2024


This change is Reviewable

@Pururun Pururun requested review from Rawa and albin-mullvad December 9, 2024 15:21
@Pururun Pururun added the Android Issues related to Android label Dec 9, 2024
@Pururun Pururun force-pushed the update-changelog-for-android-2024.9 branch from e8f4f1c to 14cce7e Compare December 9, 2024 15:22
@Pururun Pururun requested a review from kl December 9, 2024 15:22
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Pururun)


android/CHANGELOG.md line 49 at r2 (raw file):

### Security
- Remove invalidly set up alternative stack for fault signal handlers on unix based systems.

This reads a bit weird for me Remove invalidly set up alternative stack


android/CHANGELOG.md line 52 at r2 (raw file):

  This prevents potential stack overflow and heap memory corruption.
  Fixes audit issue `MLLVD-CR-24-01`.
- Remove/disable unsafe signal  code from fault signal handler on unix based systems.

Multiple spaces in signal code

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @Pururun)


android/CHANGELOG.md line 49 at r2 (raw file):

Remove alternative stack for fault signal handlers on unix based systems. It was implemented incorrectly and could cause stack overflow and heap memory corruption.

@albin-mullvad albin-mullvad force-pushed the update-changelog-for-android-2024.9 branch from 5cf3aa9 to a6d4b22 Compare December 9, 2024 15:52
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad force-pushed the update-changelog-for-android-2024.9 branch from e6f986d to ad20a8d Compare December 9, 2024 16:11
@albin-mullvad albin-mullvad changed the title Update changelog for android 2024.9 Update changelog for android/2024.9 Dec 9, 2024
@Pururun Pururun merged commit 373b9cf into prepare-android/2024.9 Dec 9, 2024
29 of 31 checks passed
@Pururun Pururun deleted the update-changelog-for-android-2024.9 branch December 9, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants