Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate RUSTSEC-2024-0421 #7318

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Mitigate RUSTSEC-2024-0421 #7318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc6921b
Update `idna` to version 1.0.3
MarkusPettersson98 Dec 10, 2024
24c602a
Revert "Silence `RUSTSEC-2024-0421`"
MarkusPettersson98 Dec 10, 2024
2c51efa
Add Unicode-3.0 to approved licenses
MarkusPettersson98 Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 27 additions & 53 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@ single_use_lifetimes = "warn"
unused_async = "deny"

[workspace.dependencies]
hickory-proto = "0.24.1"
hickory-resolver = "0.24.1"
hickory-server = { version = "0.24.1", features = ["resolver"] }
hickory-proto = "0.24.2"
hickory-resolver = "0.24.2"
hickory-server = { version = "0.24.2", features = ["resolver"] }
tokio = { version = "1.8" }
parity-tokio-ipc = "0.9"
futures = "0.3.15"
Expand Down
6 changes: 0 additions & 6 deletions deny.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,6 @@ yanked = "deny"
ignore = [
# Ignored audit issues. This list should be kept short, and effort should be
# put into removing items from the list.

# RUSTSEC-2024-0421 - `idna` accepts Punycode labels that do not produce any non-ASCII when decoded
# `hickory-proto 0.24.1` uses `idna 0.4`
# `url 2.5` uses `idna 0.5.0`
# `shadowsocks 1.20.3` uses `url 2.5`
"RUSTSEC-2024-0421",
]


Expand Down
13 changes: 0 additions & 13 deletions osv-scanner.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,16 +67,3 @@
# effectiveUntil = 2024-11-02
# reason = "The XML payload is generated by Apple tooling which we trust"
# ```

# idna accepts Punycode labels that do not produce any non-ASCII when decoded
[[IgnoredVulns]]
id = "RUSTSEC-2024-0421"
ignoreUntil = 2025-03-09
reason = """
There is a privelege escalation in the `idna` crate, which affects consumers that accept arbitrary domain names
as input, which we do not. A fix has been released in version `1.0.0`, and currently our dependencies `hickory-proto`
and `shadowsocks` prevent us from upgrading to a safe version of `idna`. New releases of these depencies which are not
vulnerable to RUSTSEC-2024-0421 is tracked in the following GitHub issues:
- https://github.com/hickory-dns/hickory-dns/issues/2206
- https://github.com/shadowsocks/shadowsocks-rust/issues/1775
"""
Loading
Loading