-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Installer Downloader] Detect native CPU arch #7709
Conversation
5150145
to
03d081c
Compare
5ab5ced
to
be52948
Compare
6994be5
to
4eef94d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion
installer-downloader/src/controller.rs
line 66 at r1 (raw file):
let Some(architecture) = get_arch().ok().flatten() else { // Could not retrieve the host's CPU architecture for whatever reason delegate.queue_main(|self_| {
Could the error handling be moved into AppController::initialize
? By passing in something like architecture: impl FnOnce() -> io::Result<VersionArchitecture>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 11 files at r1.
Reviewable status: 10 of 11 files reviewed, 2 unresolved discussions (waiting on @MarkusPettersson98)
installer-downloader/Cargo.toml
line 19 at r1 (raw file):
[dependencies] talpid-platform-metadata = { path = "../talpid-platform-metadata" }
This should be gated behind windows || macos
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion
installer-downloader/Cargo.toml
line 19 at r1 (raw file):
Previously, dlon (David Lönnhager) wrote…
This should be gated behind
windows || macos
.
Done
b978d94
to
e93e592
Compare
398ab0c
to
36fcad9
Compare
d83ceee
to
9fd34a6
Compare
3ab4e11
to
bdec95a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r2, 7 of 8 files at r3, 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
installer-downloader/src/winapi_impl/mod.rs
line 36 at r4 (raw file):
EnvError::Arch => "Failed to detect CPU architecture", }; nwg::fatal_message(title, content)
We could either use modal_fatal_message
or display this error before creating the AppWindow
at all. Currently, the MessageBox
dialog doesn't prevent the main window from being focused.
db28ddb
to
165d53d
Compare
9d51950
to
bca0791
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 10 of 15 files reviewed, all discussions resolved (waiting on @dlon)
installer-downloader/src/winapi_impl/mod.rs
line 36 at r4 (raw file):
Previously, dlon (David Lönnhager) wrote…
We could either use
modal_fatal_message
or display this error before creating theAppWindow
at all. Currently, theMessageBox
dialog doesn't prevent the main window from being focused.
Done
bca0791
to
c8c013a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r5, 3 of 3 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
c8c013a
to
c9a6b57
Compare
c9a6b57
into
installer-downloader
This change is