Use socket instead of ping command when pinging on android

[Pururun]

---

This change is 

[linear]

DROID-1825 Investigate GO crash issue with runtime.GC()

[Rawa]

We should add some message, explaining why this fixes droid-1825

[dlon]

Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions

---

talpid-wireguard/src/connectivity/pinger/mod.rs line 1 at r2 (raw file):

#[path = "icmp.rs"]

I think we should remove the renaming now:

mod icmp;

---

talpid-wireguard/Cargo.toml line 40 at r2 (raw file):

[target.'cfg(target_os="android")'.dependencies]
duct = "0.13"

duct is unused, I believe. (Remove these two lines.)

---

talpid-wireguard/src/connectivity/pinger/icmp.rs line 73 at r2 (raw file):

                Type::DGRAM
            } else {
                Type::DGRAM

Should be Type::RAW

[dlon]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Pururun)

---

talpid-wireguard/src/connectivity/pinger/icmp.rs line 65 at r2 (raw file):

    pub fn new(
        addr: Ipv4Addr,
        #[cfg(not(any(target_os = "windows", target_os = "android")))] interface_name: String,

Nit: #[cfg(any(target_os = "linux", target_os = "macos"))]

[Pururun]

Reviewable status: 2 of 5 files reviewed, 1 unresolved discussion (waiting on @dlon)

---

talpid-wireguard/Cargo.toml line 40 at r2 (raw file):

Previously, dlon (David Lönnhager) wrote…

duct is unused, I believe. (Remove these two lines.)

Done

---

talpid-wireguard/src/connectivity/pinger/icmp.rs line 65 at r2 (raw file):

Previously, dlon (David Lönnhager) wrote…

Nit: #[cfg(any(target_os = "linux", target_os = "macos"))]

Done

---

talpid-wireguard/src/connectivity/pinger/icmp.rs line 73 at r2 (raw file):

Previously, dlon (David Lönnhager) wrote…

Should be Type::RAW

Done

---

talpid-wireguard/src/connectivity/pinger/mod.rs line 1 at r2 (raw file):

Previously, dlon (David Lönnhager) wrote…

I think we should remove the renaming now:

mod icmp;

Done

[Rawa]

Reviewable status: 1 of 5 files reviewed, 2 unresolved discussions (waiting on @dlon)

---

-- commits line 2 at r4:
Please add some comment with why it relates to DROID-1825 and what it fixes so if we ever hit this again we won't have to spend an eternity. 🙏

[Rawa]

Reviewed 1 of 4 files at r1, 2 of 3 files at r3, 1 of 1 files at r4.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @dlon and @Pururun)

[dlon]

Reviewed 1 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

[Pururun]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

-- commits line 2 at r4:

Previously, Rawa (David Göransson) wrote…

Please add some comment with why it relates to DROID-1825 and what it fixes so if we ever hit this again we won't have to spend an eternity. 🙏

Updated

[Rawa]

Reviewed 1 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved