Use .is_empty() instead of .len() == 0

.github/workflows/linting.yml

@@ -0,0 +1,25 @@
+---
+name: Rust linting
+on:
+  pull_request:
+    paths:
+      - .github/workflows/linting.yml
+      - '**/*.rs'
+  workflow_dispatch:
+jobs:
+  clippy-linting:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions-rs/[email protected]
+        with:
+          toolchain: stable
+          profile: minimal
+          components: clippy
+          default: true
+
+      - name: Clippy check
+        env:
+          RUSTFLAGS: --deny warnings
+        run: cargo clippy --locked --all-targets

tests/filter_rules.rs

@@ -236,7 +236,7 @@ test!(flush_filter_rules {
     assert_matches!(pf.flush_rules(ANCHOR_NAME, pfctl::RulesetKind::Filter), Ok(()));
     assert_matches!(
         pfcli::get_rules(ANCHOR_NAME),
-        Ok(ref v) if v.len() == 0
+        Ok(ref v) if v.is_empty()
     );
 });
 

tests/redirect_rules.rs

@@ -56,7 +56,7 @@ test!(flush_redirect_rules {
         assert_matches!(pf.flush_rules(ANCHOR_NAME, pfctl::RulesetKind::Redirect), Ok(()));
         assert_matches!(
             pfcli::get_nat_rules(ANCHOR_NAME),
-            Ok(ref v) if v.len() == 0
+            Ok(ref v) if v.is_empty()
         );
     }
 });