Build in CI with --locked #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serock3
approved these changes
May 29, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
This ensures the Cargo.lock file stays up to date. If someone add or change a dependency in a way that require lockfile changes, the CI should fail. When the lockfile is versioned it has to stay up to date
faern
force-pushed
the
build-with-locked-lockfile
branch
from
b23778d to
8ac5795
Compare
|
I suppose we don't want to force gpg key signatures on commits that change the lockfile, right? |
We don't have the infrastructure in place to check GPG signatures anywhere but our main repository. The keys are locally checked in there and that's why we can do it there. We have not worked on generalizing it to be able to check other repositories. We don't really check in the lockfile in this crate for supply chain security. More for CI and debug stability/reproducibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow-up to #89
This ensures the Cargo.lock file stays up to date. If someone add or change a dependency in a way that require lockfile changes, the CI should fail. When the lockfile is versioned it has to stay up to date
This change is