Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move out bidi characters to constant #11

Merged
merged 1 commit into from
Aug 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/rules.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
/// List of bidirectional formatting characters from <https://en.wikipedia.org/wiki/Trojan_Source>
const BIDI_CHARACTERS: &[char] = &[
'\u{202A}', '\u{202b}', '\u{202c}', '\u{202d}', '\u{202e}', '\u{2066}', '\u{2067}', '\u{2068}',
'\u{2069}',
];

pub enum Decision {
Allow,
Deny,
Expand Down Expand Up @@ -59,12 +65,7 @@ impl CharacterType {
match self {
Self::CodePoint(rule_char) => *rule_char == c,
Self::Range(range) => range.contains(&c),
Self::Bidi => [
// List of bidirectional formatting characters from https://en.wikipedia.org/wiki/Trojan_Source
'\u{202A}', '\u{202b}', '\u{202c}', '\u{202d}', '\u{202e}', '\u{2066}', '\u{2067}',
'\u{2068}', '\u{2069}',
]
.contains(&c),
Self::Bidi => BIDI_CHARACTERS.contains(&c),
Self::Block(range) => range.contains(&c),
Self::Anything => true,
}
Expand Down
Loading