Separate main.rs into main.rs and lib.rs #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping main.rs slim and doing most logic in the library. * Separates CLI stuff from the functionality of the program. * Makes it possible to have doc tests in lib.rs * Can potentially make the library more testable
gregoire-mullvad
approved these changes
Oct 11, 2024
|
As discussed AFK: We want to eventually publish this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping main.rs slim and doing most logic in the library. I find that to be a good thing to strive for. Avoiding too large modules is a good idea in general. So if we can separate CLI parsing from the rest that's a good start.
This also makes it possible to attach doc tests to stuff in lib.rs. Documentation tests don't run for
main.rs. At the same time potentially makes the library part more testable, since you can write integration tests against library crates, but not binary crates.