Make unicode blocks ordered #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes --print-unicode-blocks list all blocks in the expected order instead of a random order
faern
force-pushed
the
make-unicode-blocks-ordered
branch
from
49740e2 to
9a57117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that
--print-unicode-blocksprinted all unicode blocks in a seemingly random order. Because the phf maps are not ordered! But that was an easy fix, since the same crate provides an ordered map type as well!I also realized the verbose printing, including the unicode range, was hard to read. since all the block names are of different length. So I changed it so the range is printed first. So instead of this:
We instead get this:
Which I think is way simpler to visually parse.