Generate our own unicode block constants #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregoire-mullvad
force-pushed
the
genblocks
branch
5 times, most recently
from
1203f23 to
b5942d7
Compare
faern
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Really nice!
Nitpicks:
- Add a doc comment to
UNICODE_BLOCKSand some newlines before it. Makes that generated Rust file a bit easier to read. - Make the Python script download and save
Blocks.txtso we can commit it. Makes it possible to trace back what version ofunicode_blocks.rscomes from what version ofBlocks.txt
gregoire-mullvad
force-pushed
the
genblocks
branch
2 times, most recently
from
de67b06 to
01bf99c
Compare
faern
requested changes
Aug 30, 2024
genblocks
Outdated
| for line in blocksdata.decode().splitlines(): | ||
| if match := BLOCKDEF.match(line.strip()): | ||
| name = match.group("name") | ||
| if name in {"Low Surrogates", "High Surrogates", "High Private Use Surrogates"}: |
There was a problem hiding this comment.
Would be nice with a comment on why these are ignored.
genblocks
Outdated
| @@ -0,0 +1,51 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
I would appreciate a comment at the start of this script saying approximately what it does. Makes things so much more easy to follow.
genblocks
Outdated
|
|
||
| with RSBLOCKFILE.open("w") as file: | ||
| print("#![cfg_attr(rustfmt, rustfmt_skip)]", file=file) | ||
| print("// Code generated by hack/genblocks. DO NOT EDIT.", file=file) |
There was a problem hiding this comment.
The path to self here is outdated now when it's moved out of hack/
gregoire-mullvad
force-pushed
the
genblocks
branch
2 times, most recently
from
d7a630c to
508cec6
Compare
faern
approved these changes
Aug 30, 2024
gregoire-mullvad
force-pushed
the
genblocks
branch
from
508cec6 to
c80dcd2
Compare
Add a script to generate a custom unicode_block module with constants representing unicode blocks. This replaces the blocks from unic-ucd-blocks. Also refactor CharacterType::Range to use a RangeInclusive so we can also remove the dependency on unic-char-range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a script to generate a custom unicode_block module with constants
representing unicode blocks. This replaces the blocks from
unic-ucd-blocks.
Also refactor CharacterType::Range to use a RangeInclusive so we can
also remove the dependency on unic-char-range.