-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a struct for passing daita parameters #34
Add a struct for passing daita parameters #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @acb-mv, @buggmagnet, @pinkisemils, and @rablador)
Sources/WireGuardKitGo/api-apple.go
line 167 at r1 (raw file):
//export test_daita func test_daita(context *C.DaitaGoParameters) {
Should this be removed?
Sources/WireGuardKitGo/api-apple.go
line 239 at r1 (raw file):
dev := device.NewDevice(&wrapper, conn.NewStdNetBind(), logger) return addTunnelFromDevice(dev, nil, settings, "", virtualNet, logger, maybeNotMachines, maybeNotMaxEvents, maybeNotMaxActions) // FIXME
I know it's unrelated to the PR, but "FIXME" without any explanation isn't very helpful :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @acb-mv, @buggmagnet, and @pinkisemils)
Sources/WireGuardKitGo/api-apple.go
line 102 at r1 (raw file):
var tunnels = NewTunnelHandles() func daitaParametersFromRaw(maybeNotMachines *C.char, p *C.DaitaGoParameters) daitaParameters {
Nit: Put type above func? Or maybe that's Go-specific...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @acb-mv, @buggmagnet, and @pinkisemils)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @acb-mv, @buggmagnet, and @dlon)
Sources/WireGuardKitGo/api-apple.go
line 167 at r1 (raw file):
Previously, dlon (David Lönnhager) wrote…
Should this be removed?
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @acb-mv, @buggmagnet, and @dlon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @acb-mv and @buggmagnet)
d714e76
to
f6e7705
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acb-mv and @buggmagnet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @acb-mv)
dccef53
to
8b23c76
Compare
This PR adds the necessary parameters for DaitaV2 between WireGuardKitGo and WireGuardGo
This change is