Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a struct for passing daita parameters #34

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

buggmagnet
Copy link

@buggmagnet buggmagnet commented Dec 13, 2024

This PR adds the necessary parameters for DaitaV2 between WireGuardKitGo and WireGuardGo


This change is Reviewable

Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @acb-mv, @buggmagnet, @pinkisemils, and @rablador)


Sources/WireGuardKitGo/api-apple.go line 167 at r1 (raw file):

//export test_daita
func test_daita(context *C.DaitaGoParameters) {

Should this be removed?


Sources/WireGuardKitGo/api-apple.go line 239 at r1 (raw file):

	dev := device.NewDevice(&wrapper, conn.NewStdNetBind(), logger)

	return addTunnelFromDevice(dev, nil, settings, "", virtualNet, logger, maybeNotMachines, maybeNotMaxEvents, maybeNotMaxActions) // FIXME

I know it's unrelated to the PR, but "FIXME" without any explanation isn't very helpful :D

Copy link

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @acb-mv, @buggmagnet, and @pinkisemils)


Sources/WireGuardKitGo/api-apple.go line 102 at r1 (raw file):

var tunnels = NewTunnelHandles()

func daitaParametersFromRaw(maybeNotMachines *C.char, p *C.DaitaGoParameters) daitaParameters {

Nit: Put type above func? Or maybe that's Go-specific...?

Copy link

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @acb-mv, @buggmagnet, and @pinkisemils)

Copy link

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @acb-mv, @buggmagnet, and @dlon)


Sources/WireGuardKitGo/api-apple.go line 167 at r1 (raw file):

Previously, dlon (David Lönnhager) wrote…

Should this be removed?

Yes.

Copy link

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @acb-mv, @buggmagnet, and @dlon)

Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @acb-mv and @buggmagnet)

@pinkisemils pinkisemils force-pushed the help-david-with-daitav2-for-ios-ios-928 branch from d714e76 to f6e7705 Compare December 20, 2024 08:51
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acb-mv and @buggmagnet)

Copy link

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @acb-mv)

@pinkisemils pinkisemils force-pushed the help-david-with-daitav2-for-ios-ios-928 branch from dccef53 to 8b23c76 Compare December 20, 2024 13:59
@pinkisemils pinkisemils merged commit f6c6af0 into mullvad-master Dec 20, 2024
1 check was pending
@pinkisemils pinkisemils deleted the help-david-with-daitav2-for-ios-ios-928 branch December 20, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants