Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the native prefix in front of PATH #501

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

isuruf
Copy link
Collaborator

@isuruf isuruf commented Feb 4, 2023

@radarhere
Copy link
Collaborator

While I appreciate the thought (trying to solve a problem I was having in #495), this doesn't resolve the issue for me.

Trying to run cjpeg after a universal2 build fails by default.
Using this change, it still fails.
Swapping the order of the builds works.

@isuruf
Copy link
Collaborator Author

isuruf commented Feb 6, 2023

@radarhere, try the new commit.

@radarhere
Copy link
Collaborator

radarhere commented Feb 6, 2023

Hey, that does work! Thanks very much

@mattip
Copy link
Collaborator

mattip commented Feb 6, 2023

Will there be cases this breaks something? I am not sure what the implications are of changing the $PATH.

@radarhere
Copy link
Collaborator

radarhere commented Feb 6, 2023

In case it is relevant, the second commit is what fixed my situation, independently of the first.

@mattip
Copy link
Collaborator

mattip commented Feb 9, 2023

#502 is merged. Do we still need this one?

@radarhere
Copy link
Collaborator

Not on my account. The remaining change here would actually introduce problems to pillow-wheels.

@isuruf
Copy link
Collaborator Author

isuruf commented Mar 30, 2023

How would it introduce problems?

@radarhere
Copy link
Collaborator

I've tested further and it was only a problem where a path has changed when installing xcb - something that could probably be worked around.

By no means did I want to object to this for minor reasons though. If this makes it in on its own merits, that's fine. Just don't do it to solve any probem that I had raised.

@mattip
Copy link
Collaborator

mattip commented Oct 23, 2024

Whoops, parts of this were done in #531. Do we need the other changes for cross-compiling on macos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants