forbid empty multiaddrs #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
commented
May 20, 2019
| @@ -582,11 +582,11 @@ func TestBinaryMarshaler(t *testing.T) { | |||
| t.Fatal(err) | |||
| } | |||
|
|
|||
| addr2 := newMultiaddr(t, "") | |||
| var addr2 multiaddr | |||
There was a problem hiding this comment.
This is the issue I was talking about. This could be done by manually calling NewMultiaddr before but now one needs to construct a valid multiaddr.
There was a problem hiding this comment.
but would work by creating a non-empty multiaddress (which just will be replaced) ?
There was a problem hiding this comment.
Yes, I guess. Although... multiaddrs are really supposed to be immutable. I guess this is just an unavoidable edge-case.
hsanjuan
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #104