This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
Multicodec constants #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the code more uniform, hence easier to understand.
The codec used to be defined as string. Now you can use the numbers as defined per multicodec constants. The codec is stored in a field called `code`. Ideally we would store it in `codec`, but for backwards compatibility reasons that one will still return the name of the codec as a string. New code should use `code` instead of `codec` to check for the codec a CID is using.
ghost
assigned 
|
FWIW, I vastly prefer the DX of using strings rather than numbers. |
|
@achingbrain From the DX it's is string vs. constants. |
|
Yes, but the constants are numbers, which opens the door to |
Which is the whole point in order to make custom IPLD Formats easier to add (writing down why I want this is on my TODO list). |
This was referenced May 6, 2019
Closed
|
This effort is superseded by https://github.com/multiformats/js-multiformats, which does exactly that. Thanks @mikeal for picking up that idea. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codec used to be defined as string. Now you can use the numbers as
defined per multicodec constants. The codec is stored in a field
called
code.Ideally we would store it in
codec, but for backwards compatibilityreasons that one will still return the name of the codec as a string.
New code should use
codeinstead ofcodecto check for the codeca CID is using.
This change needs multiformats/js-multicodec#35 to be merged first.