feat: get path and tuples on constructor #329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
suggested changes
Jul 11, 2023
src/codec.ts
Outdated
Comment on lines
85
to
87
| if (path == null) { | ||
| path = null | ||
| } |
There was a problem hiding this comment.
Don't get it. If value for path is not set, we are resetting it.
There was a problem hiding this comment.
check this implementation
Line 699 in 76fa6f5
when there is no path in any protocols, it means path = null and we don't need to search for it again the next time getPath() is called
I'll add more comments to this function referring to DefaultMultiaddr.getPath()
There was a problem hiding this comment.
Got it, with == you are checking for both null and `undefined.
There was a problem hiding this comment.
@nazarhussain yeah it's a bit confused, I changed the condition to if (path === undefined) instead
nazarhussain
approved these changes
Jul 12, 2023
|
closing this PR as there are further improvement in #330 |
achingbrain
pushed a commit
that referenced
this pull request
Jul 28, 2023
Taking #329 to its logical extreme, we're able to simplify the codebase (mostly `codec.ts` and its interaction with `DefaultMultiaddr`). Precalculate a `MultiaddrParts` when constructing a `DefaultMultiaddr`. `MultiaddrParts` is essentially an object containing all data which is stored in a `DefaultMultiaddr`. This makes all `DefaultMultiaddr` methods cheap, at the expense of always storing the string, bytes, tuples, stringTuples, and path of the multiaddr. The two important functions to review are `stringToMultiaddrParts` and `bytesToMultiaddrParts`, which convert untrusted string and bytes into `MultiaddrParts`. --------- Co-authored-by: Tuyen Nguyen <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
## [12.1.4](v12.1.3...v12.1.4) (2023-07-28) ### Bug Fixes * precalculate multiaddr parts ([#330](#330)) ([cf7e9c6](cf7e9c6)), closes [#329](#329) ### Trivial Changes * update project config ([#326](#326)) ([76fa6f5](76fa6f5)) ### Documentation * import from @multiformats/multiaddr ([#327](#327)) ([4dedd4b](4dedd4b)) ### Dependencies * bump multiformats from 11.0.2 to 12.0.1 ([#328](#328)) ([07d4f8a](07d4f8a)) * **dev:** bump aegir from 39.0.13 to 40.0.2 ([#333](#333)) ([3480741](3480741))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
MultiaddrInputis a stringDescription
DefaultMultiaddrwhenMultiaddrInputis a string, we already have tuples instringTuplesToTuples, just need to return it