feat(resolve): allow configurable dnsServers #341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
commented
Sep 20, 2023
Comment on lines
+98
to
+99
| * In the browser, this is passed to dns-over-http-resolver, so the servers should be a DoH compatible url such as https://cloudflare-dns.com/dns-query | ||
| * In Node.js, this is passed to dns.resolve, so the servers should be an IP address or hostname (with optional port) such as '9.9.9.9' |
There was a problem hiding this comment.
Suggested change
| * In the browser, this is passed to dns-over-http-resolver, so the servers should be a DoH compatible url such as https://cloudflare-dns.com/dns-query | |
| * In Node.js, this is passed to dns.resolve, so the servers should be an IP address or hostname (with optional port) such as '9.9.9.9' | |
| * In the browser, this is passed to [dns-over-http-resolver](https://github.com/vasco-santos/dns-over-http-resolver#setserversservers), so the servers should be a DoH compatible url such as https://cloudflare-dns.com/dns-query | |
| * In Node.js, this is passed to [dns.setServers](https://nodejs.org/api/dns.html#dnspromisessetserversservers), so the servers should be an IP address or hostname (with optional port) such as '9.9.9.9' |
|
Closing in favour of #373 as it allows specifying multiple DNS resolution strategies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to call ma.resolve() with a dnsServers option that
will allow them to override the dnsServers used when resolving /dnsaddr/xxx multiaddrs.