-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify sha3 #12
base: master
Are you sure you want to change the base?
Clarify sha3 #12
Conversation
Thanks great point. I had missed the internal state discussion and just labeled Also, I think we should have all functions:
perhaps:
? |
@jbenet I think that your last proposal makes total sense and bears no conflict (besides maybe adopting I'll be implementing it like this in |
@ivilata great sounds good. could you file a PR against this repo with code table updates you see fit? |
@ivilata sorry for the months delay on review.
i think we SHOULD keep sha3-512, as thats' what's been established so far by implementations. i wouldn't want a bad surprise for someone. |
@@ -2,6 +2,6 @@ code, name | |||
0x11, sha1 | |||
0x12, sha2-256 | |||
0x13, sha2-512 | |||
0x14, sha3 | |||
0x14, sha3-256; KECCAK[512] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this should be aliased to sha3-512
, see #22
This PR is out of date and should be closed. |
No description provided.