mptcp: check fallback if opt dropped after first data #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current kernel, the server incorrectly resets a connection if its first packet has data (< init window) and MPTCP options, but then the next ones no longer have MPTCP options. [1] The server should not reset this connection in this case, but do a fallback. It should reset the connection only if it has received a DATA_ACK, or data for more than the initial window (implying DATA_ACK have been received by the other peer) [2]. This new packetdrill test checks the expected behaviour. Link: multipath-tcp/mptcp_net-next#518 [1] Link: https://datatracker.ietf.org/doc/html/rfc8684#name-fallback [2] Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
matttbe
force-pushed
the
dss_drop_after_data_fallback
branch
from
453bc38 to
36674f0
Compare
|
The corresponding kernel patch has been applied. I suggest doing the same here to make sure there are no regressions. (I can always fix issues later) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current kernel, the server incorrectly resets a connection if its first packet has data (< init window) and MPTCP options, but then the next ones no longer have MPTCP options. [1]
The server should not reset this connection in this case, but do a fallback. It should reset the connection only if it has received a DATA_ACK, or data for more than the initial window (implying DATA_ACK have been received by the other peer) [2].
This new packetdrill test checks the expected behaviour.
Link: multipath-tcp/mptcp_net-next#518 [1]
Link: https://datatracker.ietf.org/doc/html/rfc8684#name-fallback [2]