-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test GitHub jenkins plugin comments #7
Open
multiservicio
wants to merge
16
commits into
master
Choose a base branch
from
test_github_jenkins_plugin_comments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a10d5c1
Modify jenkins base url
f96343f
Update pipeline
95147e6
More changes with poll scm
0f1683a
add echo
70cfc1e
Remove variable print
56cafca
add small change
c4f59a7
add environement variables
7268c31
change name of the credentials
ea62b3f
try another trigger
fd8cde3
another approach to the jenkinsfile
9f2889f
more changes to the pipeline for sonar runner
ae7a5c9
typo
decc725
add issues for sonar
e2182d4
add sonarqube dashboard
f136a7c
add sonar with deployment annotations
multiservicio 92dc2c0
add deployment table
multiservicio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,51 +1,37 @@ | ||
pipeline { | ||
agent any | ||
stages { | ||
stage('Lint') { | ||
steps { | ||
parallel( | ||
"Lint": { | ||
sh 'echo \'linted!\'' | ||
|
||
}, | ||
"Time": { | ||
sh 'echo "date"' | ||
|
||
} | ||
) | ||
} | ||
} | ||
stage('SonarQube analysis') { | ||
steps { | ||
// requires SonarQube Scanner 2.8+ | ||
withSonarQubeEnv('sonar') { | ||
sh "./helloworld/sonar-scanner/bin/sonar-scanner" | ||
} | ||
} | ||
} | ||
stage('Deploy') { | ||
steps { | ||
sh 'echo "Deploying..."' | ||
} | ||
} | ||
stage('Publish to Influxdb') { | ||
when { | ||
expression { | ||
currentBuild.result == null || currentBuild.result == 'SUCCESS' | ||
} | ||
} | ||
steps { | ||
echo 'Publishing to Influxdb' | ||
step([$class: 'InfluxDbPublisher', customData: null, customDataMap: null, customPrefix: null, target: 'influxdb']) | ||
} | ||
} | ||
node { | ||
stage("Prepare") { | ||
checkout scm | ||
} | ||
post { | ||
always { | ||
sh 'echo "Always in post"' | ||
} | ||
failure { | ||
sh 'echo "The Pipeline failed :("' | ||
|
||
stage('Print env') { | ||
sh 'printenv' | ||
} | ||
|
||
stage("Sonar") { | ||
|
||
// Adding variables to sonar.properties | ||
sh "echo sonar.github.repository=multiservicio/devops-docker >> sonar-project.properties" | ||
sh "echo sonar.analysis.mode=preview >> sonar-project.properties" | ||
sh "echo sonar.github.pullRequest=${pullRequestId(env.BRANCH_NAME)}>> sonar-project.properties" | ||
sh "echo sonar.github.oauth=xxxx >> sonar-project.properties" | ||
|
||
withSonarQubeEnv('sonar') { | ||
sh "./helloworld/sonar-scanner/bin/sonar-scanner" | ||
} | ||
} | ||
|
||
stage('Publish to Influxdb') { | ||
step([$class: 'InfluxDbPublisher', customData: null, customDataMap: null, customPrefix: null, target: 'influxdb']) | ||
} | ||
|
||
} | ||
|
||
/** | ||
* Get pull request id from branch string | ||
* | ||
* @param branch | ||
* @return | ||
*/ | ||
String pullRequestId(String branch) { | ||
return (branch =~ /^PR-(\d+)$/)[0][1] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
public class FooBar { | ||
|
||
public int process(int a) { | ||
int b = 0; | ||
if (a > 1 && a < 10) { | ||
return a; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
function process() { | ||
var foo = 10; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
if (i > 3) { | ||
return i; | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this unused "b" local variable.
'method def' child have incorrect indentation level 4, expected level should be 8.