added function name for pool transactions

[bogdan-rosianu]

Reasoning

• pool transactions did not have the 'function' field which would make the pool analysis easier

Proposed Changes

• add function name to pool transactions if it exists

How to test

• /transaction/pool should contain the transactions functions

[github-actions]

k6 load testing comparison.
Base Commit Hash: c051521
Target Commit Hash: e1c6460

Metric	Base				Target				Diff
	Avg	Max	90	95	Avg	Max	90	95	Avg	Max	90	95
Mex	49.33	281.15	53.33	55.21	46.18	556.83	49.75	51.22	-6.37% ✅	+98.05% 🔴	-6.71% ✅	-7.24% ✅
Tokens	49.85	397.16	53.34	55.30	45.93	368.25	49.73	51.13	-7.85% ✅	-7.28% ✅	-6.77% ✅	-7.54% ✅
Blocks	56.77	1131.67	53.86	56.35	53.07	1318.54	50.20	52.89	-6.51% ✅	+16.51% 🔴	-6.79% ✅	-6.13% ✅
Transactions	62.80	2315.24	53.82	56.78	59.40	2588.78	50.43	52.73	-5.42% ✅	+11.81% 🔴	-6.29% ✅	-7.14% ✅
Nodes	50.04	675.46	53.38	55.33	45.57	154.95	49.67	51.12	-8.94% ✅	-77.06% ✅	-6.97% ✅	-7.61% ✅
Pool	49.84	586.38	53.39	55.33	45.82	267.47	49.73	51.16	-8.06% ✅	-54.39% ✅	-6.85% ✅	-7.55% ✅
Accounts	50.21	640.28	53.31	55.21	47.16	1411.34	49.68	51.14	-6.07% ✅	+120.42% 🔴	-6.81% ✅	-7.36% ✅
Test Run Duration	60009.19				60002.56

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

[andreibancioiu]

In our Python implementation, we have a small issue with parsing some badly-formatted transactions. If the issue exists in the JS implementation, as well, a tiny failure might make the whole request fail, I think. Perhaps have a more pessimistic approach?

[andreibancioiu]

Additionally, maybe we should benchmark this? Or is the logic applied for a mere page of transactions, not all?

If applied on all currently in pool, we might have a small performance issue?

💭

[bogdan-rosianu]

a tiny failure might make the whole request fail, I think

no, if the decoding fails, it will just returned undefined, therefore not applying the function name

regarding the performance impact, it is ok since we cache the entire pool so the processing only happens once

[cfaur09]

Add also the function filter to be able to filter by multiple functions