Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search query parameter to accounts count endpoints #1441

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Jan 28, 2025

Proposed Changes

  • Added support for accounts count/c search filter

How to test

  • <api>/accounts/c?search=multiversx
  • <api>/accounts/count?search=multiversx

Copy link

k6 load testing comparison.
Base Commit Hash: d249093
Target Commit Hash: a0605b5

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Pool47.91697.3551.1153.0947.22609.5450.6252.08-1.45% ✅-12.59% ✅-0.96% ✅-1.89% ✅
Mex47.33562.2351.0853.0147.16646.2350.5651.99-0.36% ✅+14.94% 🔴-1.02% ✅-1.93% ✅
Transactions60.802551.4151.7955.0559.691651.6151.3053.47-1.83% ✅-35.27% ✅-0.94% ✅-2.87% ✅
Tokens47.25351.1551.0652.9047.41903.3450.6452.13+0.34% 🔴+157.25% 🔴-0.82% ✅-1.47% ✅
Nodes48.24935.0451.0453.0946.61113.9050.6052.03-3.38% ✅-87.82% ✅-0.85% ✅-2.01% ✅
Accounts48.451199.7451.0953.0846.71165.6350.5551.99-3.58% ✅-86.19% ✅-1.05% ✅-2.05% ✅
Blocks53.581263.2051.5356.0054.341348.9451.1253.30+1.42% 🔴+6.79% 🔴-0.80% ✅-4.83% ✅
Test Run Duration60003.5860007.27

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@cfaur09 cfaur09 self-assigned this Jan 28, 2025
@cfaur09 cfaur09 added the feature New feature or request label Jan 28, 2025
@dragos-rebegea dragos-rebegea merged commit a13ac87 into development Jan 28, 2025
5 checks passed
@dragos-rebegea dragos-rebegea deleted the API-434-add-support-for-accounts-count-search-filter branch January 28, 2025 12:42
bogdan-rosianu added a commit that referenced this pull request Jan 31, 2025
* Add search query parameter to accounts count endpoints (#1441)

* add transactions 'isScCall' filter support (#1440)

* Enhance transaction and account APIs with 'isScCall' filter support

* Enhance TransferController API by adding 'isScCall' query filter for improved transaction detail retrieval

* Enhance ElasticIndexerHelper to support 'isScCall' filter for improved query capabilities

* fixes after review

* fixes after review

* Added validatorAuction to GatewayComponentRequest enum in GatewayService, enhancing the request capabilities for transaction processing. (#1431)

---------

Co-authored-by: Catalin Faur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants