Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finished the refactor for the SC executor #404

Open
wants to merge 2 commits into
base: feat/v3.1
Choose a base branch
from
Open

Finished the refactor for the SC executor #404

wants to merge 2 commits into from

Conversation

iulianpascalau
Copy link
Contributor

  • finished the refactor for the SC executor (part 3)

sstanculeanu
sstanculeanu reviewed Dec 27, 2024
View reviewed changes
executors/multiversx/refundExecutor.go Outdated
"Args", request.Args, "SC address", request.Address, "Caller", request.CallerAddr, "error", err)
return nil, err
}
if response.Data.ReturnCode != okCodeAfterExecution {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we consider checking response and response.Data against nil here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added checks + removed duplicated code + added unit tests

executors/multiversx/refundExecutor.go
}

func (executor *refundExecutor) executeRefunds(ctx context.Context, refundIDs map[uint64]bridgeCore.ProxySCCompleteCallData, scProxyAddress string) error {
networkConfig, err := executor.proxy.GetNetworkConfig(ctx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not cache the config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the SDK already caches the config, as seen here https://github.com/multiversx/mx-sdk-go/blob/888942f27039e743ad20e1169637a3da99abbb99/blockchain/baseProxy.go#L75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstanculeanu sstanculeanu sstanculeanu approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iulianpascalau @sstanculeanu