Mempool optimization: on transaction addition, call "GetTransferredValue" and retain its value #6641
Conversation
| if check.IfNil(args.txGasHandler) { | ||
| return nil, dataRetriever.ErrNilTxGasHandler | ||
| } | ||
| if check.IfNil(args.marshalizer) { | ||
| return nil, dataRetriever.ErrNilMarshalizer | ||
| } |
There was a problem hiding this comment.
Somehow superfluous checks (dependencies are verified one layer above, as well), should I remove them?
| } | ||
|
|
||
| // GetTransferredValue returns the value transferred by a transaction. | ||
| func (host *mempoolHost) GetTransferredValue(tx data.TransactionHandler) *big.Int { |
There was a problem hiding this comment.
Function moved from SelectionSession, no other change.
| require.NotNil(t, host) | ||
| } | ||
|
|
||
| func TestMempoolHost_GetTransferredValue(t *testing.T) { |
There was a problem hiding this comment.
Tests simply moved from selectionSession_test.go.
| argsParser := parsers.NewCallArgsParser() | ||
|
|
||
| esdtTransferParser, err := parsers.NewESDTTransferParser(args.marshalizer) |
There was a problem hiding this comment.
why not get these two as arguments as well?
There was a problem hiding this comment.
We instantiate them within mempoolHost, so that shardedTxPool doesn't have knowledge on the components from VM common parsers - somehow, a bit of information hiding (even though both mempoolHost and shardedTxPool live in the same package).
dataRetriever/txpool/mempoolHost.go
Outdated
| maybeMultiTransfer := bytes.HasPrefix(data, []byte(core.BuiltInFunctionMultiESDTNFTTransfer)) | ||
| if !maybeMultiTransfer { | ||
| // Early exit (optimization). | ||
| return nil |
There was a problem hiding this comment.
wouldn't it be easier/safer to return big.NewInt(0) here? (and L79, L84, L88)
Reasoning behind the pull request
MultiESDTNFTTransfertransactions in order to recover transfers of the native currency incurs a non-negligible performance cost.Proposed changes
TransferredValuewhen adding the transaction in the mempool (just like we do forFee). Use the information at selection time.SelectionSession.GetTransferredValue()toMempoolHost.GetTransferredValue().shardedTxPoolclass.Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?