GRPC and NotifierConfig update #6744
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axenteoctavian
changed the title
axenteoctavian
changed the title
mariusmihaic
reviewed
Feb 6, 2025
| @@ -39,6 +39,7 @@ | |||
| ] | |||
|
|
|||
| [OutGoingBridge] | |||
| Enabled = false | |||
There was a problem hiding this comment.
Can we also add a comment explaining this, similar to the one from [NotifierConfig] ?
| section_found = True | ||
| if section_found and "Enabled" in line: | ||
| line = re.sub(r'(Enabled\s*=\s*)\w+', r'\1true', line) | ||
| section_found = False |
There was a problem hiding this comment.
Why do you set this to false since you don't use it afterwards?
There was a problem hiding this comment.
This will skip the second if and will not check "Enabled" in line every time.
| def update_sovereign_config(file_path, main_chain_address, sovereign_chain_address): | ||
| with open(file_path, 'r') as file: | ||
| lines = file.readlines() | ||
|
|
||
| updated_lines = update_subscribed_addresses(lines, "OutgoingSubscribedEvents", "deposit", sovereign_chain_address) | ||
| updated_lines = update_subscribed_addresses(updated_lines, "NotifierConfig", "deposit", main_chain_address) | ||
| updated_lines = update_subscribed_addresses(updated_lines, "NotifierConfig", "execute", main_chain_address) | ||
| updated_lines = enable_key(updated_lines, "OutGoingBridge") |
There was a problem hiding this comment.
What does this do exactly?
There was a problem hiding this comment.
This will set Enabled = true in [OutGoingBridge] section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?