-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sovereign] Fix revert RestoreBlockIntoPools #6753
[sovereign] Fix revert RestoreBlockIntoPools #6753
Conversation
…d on extended headers
…oolsShouldWork
# Conflicts: # process/block/sovereignChainBlock.go
scbp.blockTracker.RemoveLastNotarizedHeaders() | ||
|
||
// TODO: MX-16507: check how/if to restore incoming scrs/cross chain txs once we have a testnet setup for it | ||
// 1. For incoming scrs We should probably have something similar to (sp *shardProcessor) rollBackProcessedMiniBlocksInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually we shouldn't really have any rollbacks anymore :D
Like with one shot finality. And we can aim for that as Andromeda is going to be released.
Merging Andromeda into this code, and what is once voted, it is a finished block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's super awesome, actually, would simplify things a lot !
if headerInfo.usedInBlock { | ||
hdrsForCurrentBlock = append(hdrsForCurrentBlock, headerInfo.hdr) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might do it on another PR
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
Reasoning behind the pull request
Proposed changes
sortExtendedShardHeadersForCurrentBlockByNonce
sorts the actual extended headers from the current block proposed by leaderFixes for
RestoreBlockIntoPools
:restoreExtendedHeaderIntoPool
RemoveLastCrossNotarizedHeaders
separately if the current header contains a notarized extended headerTesting procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?