Handle transferValueOnly events #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
commented
Aug 23, 2024
server/services/constants.go
Outdated
Comment on lines
62
to
63
| numTopicsOfEventTransferValueOnlyBeforeSirius = 3 | ||
| numTopicsOfEventTransferValueOnlyAfterSirius = 2 |
There was a problem hiding this comment.
andreibancioiu
commented
Aug 23, 2024
Comment on lines
+47
to
+48
| transactionEventDataExecuteOnDestContext = "ExecuteOnDestContext" | ||
| transactionEventDataAsyncCall = "AsyncCall" |
There was a problem hiding this comment.
Validated empirically. For other kinds of event.Data, the balance-changing operation is already captured in a SCR, thus, for those, we discard the "transferValueOnly" events.
andreibancioiu
commented
Aug 23, 2024
|
|
||
| for _, event := range rawEvents { | ||
| if isBeforeSirius { | ||
| typedEvent, err := controller.decideEffectiveEventTransferValueOnlyBeforeSirius(event) |
There was a problem hiding this comment.
Logic for "before Sirius" was kept as it was (even though it has only been validated for non-contract addresses).
andreibancioiu
commented
Aug 23, 2024
Comment on lines
+118
to
+133
| if string(event.Data) != transactionEventDataExecuteOnDestContext && string(event.Data) != transactionEventDataAsyncCall { | ||
| // Ineffective event, since the balance change is already captured by a SCR. | ||
| return nil, nil | ||
| } | ||
|
|
||
| sender := event.Address | ||
| senderPubKey, err := controller.provider.ConvertAddressToPubKey(sender) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| isIntrashard := controller.provider.ComputeShardIdOfPubKey(senderPubKey) == controller.provider.ComputeShardIdOfPubKey(receiverPubKey) | ||
| if !isIntrashard { | ||
| // Ineffective event, since the balance change is already captured by a SCR. | ||
| return nil, nil | ||
| } |
There was a problem hiding this comment.
Conditions only in the "after Sirius" logic (as far as we know, for now).
schimih
approved these changes
Aug 26, 2024
danidrasovean
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(even though its correctness has only been validated on non-contract accounts)- no handling of such events: https://github.com/multiversx/mx-chain-rosetta/blob/v0.4.4/server/services/transactionsTransformer.go#L325.transferValueOnly.