Check implementation using Mesh CLI, within GitHub Actions #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
commented
Aug 5, 2024
| """ | ||
|
|
||
| command = [ | ||
| "rosetta-cli", |
There was a problem hiding this comment.
Still, this is the name of the binary installed through mesh-cli's installer.
andreibancioiu
commented
Aug 5, 2024
Comment on lines
+83
to
+84
| data["metrics"].(map[string]interface{})["erd_app_version"] = "v1.2.3" | ||
| data["metrics"].(map[string]interface{})["erd_public_key_block_sign"] = "00" |
There was a problem hiding this comment.
Here, we are using some dummy values.
andreibancioiu
commented
Aug 5, 2024
| - name: Install dependencies | ||
| run: | | ||
| pip3 install requests bottle | ||
| curl -sSfL https://raw.githubusercontent.com/coinbase/mesh-cli/master/scripts/install.sh | sh -s -- -b "$HOME/.local/bin" |
There was a problem hiding this comment.
andreibancioiu
commented
Aug 5, 2024
| mode = args.mode | ||
| configuration = CONFIGURATIONS[args.network] | ||
|
|
||
| process_rosetta = run_rosetta(configuration) |
There was a problem hiding this comment.
We start 3 processes: Rosetta, the API adapter and Rosetta (Mesh) CLI checker.
andreibancioiu
commented
Aug 5, 2024
Comment on lines
+108
to
+109
| f"--online-url=http://localhost:{constants.PORT_ROSETTA}", | ||
| f"--offline-url=http://localhost:{constants.PORT_ROSETTA}", |
There was a problem hiding this comment.
Same URL for online & offline (on purpose).
popenta
approved these changes
Aug 5, 2024
andreibancioiu
commented
Aug 5, 2024
| "account_identifier": { | ||
| "address": "erd1ldjsdetjvegjdnda0qw2h62kq6rpvrklkc5pw9zxm0nwulfhtyqqtyc4vq" | ||
| }, | ||
| "privkey": "3e4e89e501eb542c12403fb15c52479e8721f2f4dedc3b3ef0f3b47b37de006c", |
There was a problem hiding this comment.
The testing key is not hidden, but this shouldn't be an issue for now. In the future, we will have it as a GH secret.
danielailie
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run Rosetta Checker (mesh-cli) on GitHub Actions, against the Testnet Gateway. Since Rosetta only knows to talk to an Observer, an additional proxy-to-observer API adapter was needed.