add python script to update go.mod with a specific hash in pipeline #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1 @@ | |||
| requests==2.32.3 | |||
There was a problem hiding this comment.
where do we need this file?
There was a problem hiding this comment.
this are python packages related to the script
| print(f"Latest commit hash received: {latest_commit_hash}") | ||
|
|
||
| update_go_mod_file(go_mod_path, latest_commit_hash) | ||
|
|
There was a problem hiding this comment.
trigger a run for the go mod tidy command here?
iulianpascalau
requested changes
Aug 6, 2024
btc-fan
force-pushed
the
integrate-sys-tests-ci
branch
from
2f4a105 to
93b1dd1
Compare
…nch from mx-chain-go and substitute it in go.mod file add python script that parse latest commit from a specific target branch from mx-chain-go and substitute it in go.mod file update structure in order to pass the hash to a python script fix the regex fix go.mod path fix regex fix regex fix regex fix regex revert regex revert regex use old regex use old regex fix PR comments fix PR comments
btc-fan
force-pushed
the
integrate-sys-tests-ci
branch
from
93b1dd1 to
03d7bbf
Compare
Done. Now I have just 1 signed commit |
iulianpascalau
previously approved these changes
Aug 7, 2024
miiu96
reviewed
Aug 7, 2024
| @@ -0,0 +1 @@ | |||
| requests==2.32.3 | |||
There was a problem hiding this comment.
add empty line at the end of the file
| print(f"Failed to run go mod tidy: {e.stderr}") | ||
| sys.exit(1) | ||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
define a 'main' function and call this function in this section
if name == "main":
main()
iulianpascalau
previously approved these changes
Aug 7, 2024
AdoAdoAdo
previously approved these changes
Aug 8, 2024
btc-fan
force-pushed
the
integrate-sys-tests-ci
branch
from
7a41cde to
07a714d
Compare
iulianpascalau
approved these changes
Aug 8, 2024
AdoAdoAdo
approved these changes
Aug 8, 2024
miiu96
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.