integration tests update for new contract version, added new test #11
+115
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusmihaic
previously approved these changes
Mar 6, 2025
| // - deposit the token in esdt-safe contract | ||
| // - check the sender balance is correct | ||
| // - check the token burned amount is correct after deposit | ||
| func TestSovereignChainSimulator_DeployBridgeContractsAndDepositMainChainToken(t *testing.T) { |
There was a problem hiding this comment.
[optional]
So this test "manually" -aka SetKeyValueForAddress + SetEsdtInWallet creates this main chain token in the sovereign chain as if it was previously bridged from main->sov.
Wouldn't it be a more interesting test to bring those main chain tokens first from main->sov, instead of "artifically" planting them here?
Just a thought, could've made the test more "real-life", could be done in another PR if you see it suitable
There was a problem hiding this comment.
Added task MX-16637 for this improvement
mariusmihaic
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?