User persister factory in storage unit #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storageUnit/storageunit.go
Outdated
| @@ -378,21 +374,14 @@ type ArgDB struct { | |||
| } | |||
|
|
|||
| // NewDB creates a new database from database config | |||
| func NewDB(argDB ArgDB) (types.Persister, error) { | |||
| // TODO: refactor to integrate retries loop into persister factory; maybe implement persister | |||
| // factory separatelly in storage repo | |||
There was a problem hiding this comment.
remove extra indent?
| func NewDB(argDB ArgDB) (types.Persister, error) { | ||
| // TODO: refactor to integrate retries loop into persister factory; maybe implement persister | ||
| // factory separatelly in storage repo | ||
| func NewDB(persisterFactory PersisterFactoryHandler, path string) (types.Persister, error) { |
There was a problem hiding this comment.
for extra protection (even if this is temporary) I would add a nil check for the provided persisterFactory. Maybe make the interface implement NilInterfaceChecker interface?
iulianpascalau
approved these changes
Dec 5, 2023
BeniaminDrasovean
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.