Convert state changes. #25
Conversation
| } | ||
|
|
||
| message StateChange { | ||
| string Type = 1; |
There was a problem hiding this comment.
we should think of having enum for Type instead of string
process/outportBlockConverter.go
Outdated
| s := &hyperOutportBlocks.StateChanges{StateChanges: ss} | ||
| shardStateChanges[key] = s |
There was a problem hiding this comment.
please avoid single letter variable here, maybe set it directly
There was a problem hiding this comment.
i think state changes has to be covered also for meta outport block
There was a problem hiding this comment.
it is also covered. but since the structure is the same the metaOutportBlock object will be casted automatically. The handler function is strictly for the shardOutportBlocks.
| ], | ||
| "highestFinalBlockNonce": 0, | ||
| "stateChanges": { | ||
| "M�hᎧ\u001fG\u0006�f�鼖+:bg⾩�1,�\u0015^��\t\u0018": { |
There was a problem hiding this comment.
can we have the hashes encoded as hex or erd? and decode it in tests if needed
There was a problem hiding this comment.
the state changes were taken with the state changes collector available in the node. This change should be relflected there as well.
|
Need to take this PRs into consideration: |
| } | ||
|
|
||
| enum ActionType { | ||
| Read = 0; |
There was a problem hiding this comment.
For the firehose integration we need to make sure that we configure the node to only collect write operations, otherwise there will be too much data.
No description provided.